You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first PR to migrate from the AdonisJS encryption module to @boringnode/encryption.
@boringnode/encryption provides support for multiple encryption algorithms and a proper key rotation strategy.
Regarding message signing and verification: I started looking at the MessageVerifier that currently lives inside the encryption module. It might make more sense to move it into the core module instead, and rely on a single SIGN_KEY value in the core (app.ts configuration file). That way, we wouldn't need to instantiate a MessageVerifier for every key used by the encryption module.
For context: I'm not using the encryption module MessageVerifier directly. Only the legacy encryption driver inside the core currently makes use of it (and other part of the framework).
Regarding message signing and verification: I started looking at the MessageVerifier that currently lives inside the encryption module. It might make more sense to move it into the core module instead, and rely on a single SIGN_KEY value in the core (app.ts configuration file). That way, we wouldn't need to instantiate a MessageVerifier for every key used by the encryption module.
One would still be able to create a custom verifier though?
We had an internal discussion with Aman on this topic. After some consideration, we decided to keep the MessageVerifier inside the encryption package, but without coupling it to any specific encryption driver.
Instead, the package will expose the MessageVerifier class so it can be instantiated freely by any consumer. This means the default verifier can be used as-is, and anyone who wants a custom verifier will still be able to create their own instance.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! 👋🏻
This is the first PR to migrate from the AdonisJS encryption module to
@boringnode/encryption.@boringnode/encryptionprovides support for multiple encryption algorithms and a proper key rotation strategy.Regarding message signing and verification: I started looking at the
MessageVerifierthat currently lives inside the encryption module. It might make more sense to move it into the core module instead, and rely on a singleSIGN_KEYvalue in the core (app.tsconfiguration file). That way, we wouldn't need to instantiate aMessageVerifierfor every key used by the encryption module.For context: I'm not using the encryption module
MessageVerifierdirectly. Only the legacy encryption driver inside the core currently makes use of it (and other part of the framework).